Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "main" abbreviation as the alias of "psvm" #1176

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

junichi11
Copy link
Member

No description provided.

Copy link

@svatoun svatoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just please be confident that the abbreviation is not "too general": The difference between typing and expansion is just main<SPACE> vs. main<TAB>

@junichi11
Copy link
Member Author

@svatoun Thank you for reviewing it! Yes. I also think so. set and map are as well? They are already included by default. If some users don't expect it, they can remove it easily as a workaround.

@sdedic
Copy link
Member

sdedic commented Mar 28, 2019

Good examples (map, set). Actually I do not remember these abbreviations got in my way, so the same is hopefully true for main as well. The only possble clash is on class level, but I can't think of "regular" case when main+tab is used; even the user declares main field, the next typed character is most likely ; space or =.

Copy link
Member

@geertjanw geertjanw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. :-)

@junichi11
Copy link
Member Author

Merging.

@junichi11 junichi11 merged commit 45231de into apache:master Mar 29, 2019
@junichi11 junichi11 deleted the java-main-abbreviation branch March 29, 2019 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants