Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "main" abbreviation as the alias of "psvm" #1176

Merged
merged 1 commit into from Mar 29, 2019

Conversation

@junichi11
Copy link
Member

commented Mar 28, 2019

No description provided.

@junichi11 junichi11 requested review from geertjanw and sdedic Mar 28, 2019

@svatoun
Copy link

left a comment

Just please be confident that the abbreviation is not "too general": The difference between typing and expansion is just main<SPACE> vs. main<TAB>

@junichi11

This comment has been minimized.

Copy link
Member Author

commented Mar 28, 2019

@svatoun Thank you for reviewing it! Yes. I also think so. set and map are as well? They are already included by default. If some users don't expect it, they can remove it easily as a workaround.

@sdedic

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

Good examples (map, set). Actually I do not remember these abbreviations got in my way, so the same is hopefully true for main as well. The only possble clash is on class level, but I can't think of "regular" case when main+tab is used; even the user declares main field, the next typed character is most likely ; space or =.

@geertjanw
Copy link
Member

left a comment

Cool. :-)

@junichi11

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

Merging.

@junichi11 junichi11 merged commit 45231de into apache:master Mar 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@junichi11 junichi11 deleted the junichi11:java-main-abbreviation branch Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.