[NETBEANS-2381] JDK 12 ver string support in nbi native win launcher #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtaneja1
changed the title
|
Looks sane - should be squashed on merge. (I just looked at the changes and can't comment on the compilation). |
|
Part fix was done in this: #734 |
|
Can someone please review/approve? |
|
Thanks, to me it makes sense. |
sdedic
reviewed
May 9, 2019
sdedic
approved these changes
May 9, 2019
|
Thanks Svata, created NETBEANS-2528 to track build number issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handled JDK 11, 12 release version string like 11+28, 12+33.
Also registry entry path has changed.
icon.ico was still old NetBeans icon, copied from nb/ide.launcher/windows/netbeans.ico
Build nlw.exe as per : http://wiki.netbeans.org/LauncherBuild
But removed -mno-cygwin arg as compilation fails if this is present.
Updated binary zip.