Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-1974] Gradle JavaEE Support #1215

Merged
merged 5 commits into from Jun 4, 2019

Conversation

@lkishalmi
Copy link
Contributor

commented Apr 24, 2019

No description provided.

@lkishalmi lkishalmi requested a review from JaroslavTulach Apr 24, 2019

@JaroslavTulach
Copy link
Contributor

left a comment

I haven't found a single test. That would be helpful. I left few comments inline. Nothing looks like a blocker.

}

@Override
public void beforeSave(WindowSystemEvent event) {

This comment has been minimized.

Copy link
@JaroslavTulach

JaroslavTulach May 3, 2019

Contributor

That is ugly.

This comment has been minimized.

Copy link
@lkishalmi

lkishalmi May 4, 2019

Author Contributor

Well, I do not really know why this one implemented this way, though it is how the Maven and Ant integration of the web project does that. I've just repeated the pattern.

}

private String showBrowserOnRun() {
Boolean show = (Boolean) project.getProjectDirectory().getAttribute(CustomizerRunWar.PROP_SHOW_IN_BROWSER);

This comment has been minimized.

Copy link
@JaroslavTulach

JaroslavTulach May 3, 2019

Contributor

Attribute on a filesystem? In case of projects I'd expect some AuxiliaryConfiguration to store it.

This comment has been minimized.

Copy link
@lkishalmi

lkishalmi May 4, 2019

Author Contributor

That's how Maven Java EE does it. Though I do not have to follow that. I'm going to change the implementation.

<!DOCTYPE filesystem PUBLIC "-//NetBeans//DTD Filesystem 1.2//EN" "http://www.netbeans.org/dtds/filesystem-1_2.dtd">
<filesystem>
<folder name="Projects">
<folder name="com-kenai-lkishalmi-netbeans-gradle">

This comment has been minimized.

Copy link
@JaroslavTulach

JaroslavTulach May 3, 2019

Contributor

Non-Apache package name is surprising.

This comment has been minimized.

Copy link
@lkishalmi

lkishalmi May 4, 2019

Author Contributor

Thanks, to point that out. Leftover from the refactoring.

@@ -228,6 +228,7 @@
<friend-packages>
<friend>com.sun.eview.project</friend>
<friend>org.codehaus.mevenide.netbeans.j2ee</friend>
<friend>org.netbeans.modules.gradle.javaee</friend>

This comment has been minimized.

Copy link
@JaroslavTulach

JaroslavTulach May 3, 2019

Contributor

It would be better to open to up these modules to general use and just state that they are "under development".

This comment has been minimized.

Copy link
@lkishalmi

lkishalmi May 4, 2019

Author Contributor

That would be certainly welcome, though that may be a different issue and a different PR.

@lkishalmi lkishalmi force-pushed the lkishalmi:NETBEANS-1974 branch from 5484992 to e5d7842 Jun 4, 2019

@geertjanw geertjanw added the NB11.1 label Jun 4, 2019

@lkishalmi lkishalmi merged commit 31fb740 into apache:master Jun 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lkishalmi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2019

Let's have this on the master. I hope Java EE 8 arrives there soon, so I can integrate that one and the debug support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.