[NETBEANS-1974] Gradle JavaEE Support #1215
Conversation
| } | ||
|
|
||
| @Override | ||
| public void beforeSave(WindowSystemEvent event) { |
There was a problem hiding this comment.
Well, I do not really know why this one implemented this way, though it is how the Maven and Ant integration of the web project does that. I've just repeated the pattern.
| } | ||
|
|
||
| private String showBrowserOnRun() { | ||
| Boolean show = (Boolean) project.getProjectDirectory().getAttribute(CustomizerRunWar.PROP_SHOW_IN_BROWSER); |
There was a problem hiding this comment.
Attribute on a filesystem? In case of projects I'd expect some AuxiliaryConfiguration to store it.
There was a problem hiding this comment.
That's how Maven Java EE does it. Though I do not have to follow that. I'm going to change the implementation.
| <!DOCTYPE filesystem PUBLIC "-//NetBeans//DTD Filesystem 1.2//EN" "http://www.netbeans.org/dtds/filesystem-1_2.dtd"> | ||
| <filesystem> | ||
| <folder name="Projects"> | ||
| <folder name="com-kenai-lkishalmi-netbeans-gradle"> |
There was a problem hiding this comment.
Non-Apache package name is surprising.
There was a problem hiding this comment.
Thanks, to point that out. Leftover from the refactoring.
| @@ -228,6 +228,7 @@ | |||
| <friend-packages> | |||
| <friend>com.sun.eview.project</friend> | |||
| <friend>org.codehaus.mevenide.netbeans.j2ee</friend> | |||
| <friend>org.netbeans.modules.gradle.javaee</friend> | |||
There was a problem hiding this comment.
It would be better to open to up these modules to general use and just state that they are "under development".
There was a problem hiding this comment.
That would be certainly welcome, though that may be a different issue and a different PR.
junichi11
added
Gradle
server is added from the wizard itself.
|
Let's have this on the master. I hope Java EE 8 arrives there soon, so I can integrate that one and the debug support. |
No description provided.