Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-2417] Gradle Logo Updates #1311

Closed
wants to merge 3 commits into from

Conversation

jlstrater
Copy link

This is a follow-up to #1269 (comment)

The design team recommended the use of this light grey icon for both the dark and light backgrounds. It's the same icon used by IntelliJ and that I'll submit to Eclipse as well.

As for the licenses, I checked and these are Apache 2 licensed so no change to the license file is necessary.

@junichi11 junichi11 added the Gradle [ci] enable "build tools" tests label Jun 21, 2019
@junichi11 junichi11 requested a review from lkishalmi June 21, 2019 06:25
@jlstrater jlstrater changed the title Gradle Logo Updates [NETBEANS-2417] Gradle Logo Updates Jun 26, 2019
@louhy
Copy link

louhy commented Jun 29, 2019

There is also this semi-related issue with the "red coffee cups" obscuring red error indicators:
https://issues.apache.org/jira/browse/NETBEANS-2608

Demonstrated here on the left (with old ones from other PR on right), with NB default and Darcula light/dark themes: https://imgur.com/yZYqTY7

I have to say I'm disappointed we aren't getting the blue versions, IMO they looked much better alongside NB's other color schemes. IntelliJ has a different design where they don't show the icon in their main workspace (it's only one "project" at a time anyway), and IIRC Eclipse doesn't use icons at all in their main workspace. NetBeans design is different in that it uses colored icons for each project.

The grey isn't as bad on the dark background, but on the default NetBeans white background the grey icons are almost invisible to me. Grey kinda makes me think "disabled/inactive" in this context.

(Also I think NetBeans already uses greyed-out icons to indicate "de-activated module" project types when creating a new project, but that's a minor issue.)

Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my main concerns here: in the JIRA ISSUE

@jlstrater
Copy link
Author

Please refer to #1269

@jlstrater jlstrater closed this Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gradle [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants