Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETBEANS-3020 Cleanup Welcome screen #1457

Merged
merged 15 commits into from Sep 4, 2019

Conversation

@geertjanw
Copy link
Member

commented Aug 23, 2019

Remove the left panel in the 'What's New' tab and change 'Blogs' to 'News' in the right panel, so that the Apache NetBeans blogs provides the news in the Welcome Screen and so that the dependency on netbeans.org is removed.

@geertjanw geertjanw added the NB11.2 label Aug 23, 2019

@junichi11 junichi11 added this to the 11.2 milestone Aug 24, 2019

@geertjanw geertjanw requested review from neilcsmith-net, vieiro and jkovalsky and removed request for vieiro and neilcsmith-net Aug 24, 2019

@jkovalsky
Copy link
Contributor

left a comment

Looks fine in my opinion. We might consider linking the https://netbeans.apache.org/kb/docs page where appropriate as suggested in my review.

@@ -64,19 +60,19 @@ ACD_AllNews=Open the list of all news articles in the default web browser

LBL_AllArticles=All Tutorials >>
#NOI18N
URL_AllArticles=http://netbeans.org/kb/kb.html?utm_source=netbeans&utm_campaign=welcomepage
URL_AllArticles=https://netbeans.apache.org/help/index.html

This comment has been minimized.

Copy link
@jkovalsky

jkovalsky Aug 27, 2019

Contributor

This comment has been minimized.

Copy link
@geertjanw

geertjanw Aug 29, 2019

Author Member

Problem is that the https://netbeans.apache.org/kb/docs/index.html page is incomplete at the moment and better not to expose it too much right now.

@YTN01

This comment has been minimized.

Copy link

commented Aug 28, 2019

I saw few lines that got commented out. Any reason for not removing them?

@geertjanw

This comment has been minimized.

Copy link
Member Author

commented Aug 29, 2019

I saw few lines that got commented out. Any reason for not removing them?

True, fixing that.

@geertjanw
Copy link
Member Author

left a comment

I would suggest that right now we don't highlight https://netbeans.apache.org/kb/docs/, because it is incomplete. And taking a tour would be better to start I think on the homepage instead of on the docs page.

@geertjanw geertjanw requested review from neilcsmith-net and vieiro Aug 29, 2019

@neilcsmith-net
Copy link
Member

left a comment

In principle looks good (not tested). In some ways would prefer we used IDE specific inbound links under /nb for consistency - eg. https://netbeans.apache.org/nb/help/ then handle that via redirect in .htaccess so we don't hard-code the destinations, but happy this way too.

Would be good to drop the index.html bit off the end of URLs to keep them clean. eg. https://netbeans.apache.org/help/ would be better.

Obviously this will need squashing when merging.

https://netbeans.apache.org/kb/docs/php/index.html

This comment has been minimized.

Copy link
@vieiro

vieiro Sep 1, 2019

Contributor

Hi @geertjanw , @neilcsmith-net , what about keeping the the "?utm_source=netbeans&utm_campaign=welcomepage" suffix even in the new URL? Who knows, maybe we can detect requests in the future...

@vieiro
vieiro approved these changes Sep 1, 2019
Copy link
Contributor

left a comment

Great job, @geertjanw !
Added a comment about keeping the "?utm_source=netbeans&utm_campaign=welcomepage" suffixes. We aren't able to track those right now, but who knows, maybe we can talk to Infra and see if they can help us track requests from the IDE.

@neilcsmith-net

This comment has been minimized.

Copy link
Member

commented Sep 1, 2019

@vieiro aside from flexibility to redirect, the other reason for keeping links inbound from the IDE under /nb/ was to allow for the option of tracking requests separately.

@vieiro

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

@neilcsmith-net I know. Whatever is simpler for @geertjanw would do. Not sure we will be able to track anything, though (that's Infra business, IIRC).

@geertjanw

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

I'm going to keep this PR as it is, if we need to do other things in this area, we can handle it via other PRs and issues. Thanks for the comments, squashing and merging now.

@geertjanw geertjanw merged commit ec35815 into apache:master Sep 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.