NETBEANS-3020 Cleanup Welcome screen#1457
Conversation
geertjanw
requested review from
jkovalsky,
neilcsmith-net and
vieiro
and removed request for
neilcsmith-net and
vieiro
jkovalsky
left a comment
jkovalsky
left a comment
There was a problem hiding this comment.
Looks fine in my opinion. We might consider linking the https://netbeans.apache.org/kb/docs page where appropriate as suggested in my review.
| LBL_AllArticles=All Tutorials >> | ||
| #NOI18N | ||
| URL_AllArticles=http://netbeans.org/kb/kb.html?utm_source=netbeans&utm_campaign=welcomepage | ||
| URL_AllArticles=https://netbeans.apache.org/help/index.html |
There was a problem hiding this comment.
Maybe https://netbeans.apache.org/kb/docs/index.html here would be better?
There was a problem hiding this comment.
Problem is that the https://netbeans.apache.org/kb/docs/index.html page is incomplete at the moment and better not to expose it too much right now.
|
I saw few lines that got commented out. Any reason for not removing them? |
True, fixing that. |
geertjanw
left a comment
geertjanw
left a comment
There was a problem hiding this comment.
I would suggest that right now we don't highlight https://netbeans.apache.org/kb/docs/, because it is incomplete. And taking a tour would be better to start I think on the homepage instead of on the docs page.
neilcsmith-net
left a comment
neilcsmith-net
left a comment
There was a problem hiding this comment.
In principle looks good (not tested). In some ways would prefer we used IDE specific inbound links under /nb for consistency - eg. https://netbeans.apache.org/nb/help/ then handle that via redirect in .htaccess so we don't hard-code the destinations, but happy this way too.
Would be good to drop the index.html bit off the end of URLs to keep them clean. eg. https://netbeans.apache.org/help/ would be better.
Obviously this will need squashing when merging.
| @@ -1 +1 @@ | |||
| http://netbeans.org/kb/trails/php.html?utm_source=netbeans&utm_campaign=welcomepage No newline at end of file | |||
| https://netbeans.apache.org/kb/docs/php/index.html No newline at end of file | |||
There was a problem hiding this comment.
Hi @geertjanw , @neilcsmith-net , what about keeping the the "?utm_source=netbeans&utm_campaign=welcomepage" suffix even in the new URL? Who knows, maybe we can detect requests in the future...
vieiro
left a comment
vieiro
left a comment
There was a problem hiding this comment.
Great job, @geertjanw !
Added a comment about keeping the "?utm_source=netbeans&utm_campaign=welcomepage" suffixes. We aren't able to track those right now, but who knows, maybe we can talk to Infra and see if they can help us track requests from the IDE.
|
@vieiro aside from flexibility to redirect, the other reason for keeping links inbound from the IDE under |
|
@neilcsmith-net I know. Whatever is simpler for @geertjanw would do. Not sure we will be able to track anything, though (that's Infra business, IIRC). |
|
I'm going to keep this PR as it is, if we need to do other things in this area, we can handle it via other PRs and issues. Thanks for the comments, squashing and merging now. |
| @@ -97,7 +89,7 @@ URL_IncubatorLogo=http://incubator.apache.org | |||
| #NOI18N | |||
| URL_ApacheLogo=http://www.apache.org | |||
7 participants
Remove the left panel in the 'What's New' tab and change 'Blogs' to 'News' in the right panel, so that the Apache NetBeans blogs provides the news in the Welcome Screen and so that the dependency on netbeans.org is removed.