[NETBEANS-3096]:Updation for external nb-javac jar in libs.javacapi a… #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd libs.javaimpl modules with nb-javac jar for jdk-13
arusinha-zz
commented
Sep 15, 2019
| @@ -101,7 +101,9 @@ | |||
| private static final ThreadLocal<Boolean> isTreeLoading = new ThreadLocal<Boolean>(); | |||
|
|
|||
| public static void preRegister(final Context context, final ClasspathInfo cpInfo, final boolean detached) { | |||
| context.put(lazyTreeLoaderKey, new TreeLoader(context, cpInfo, detached)); | |||
| LazyTreeLoader instance = context.get(lazyTreeLoaderKey); | |||
There was a problem hiding this comment.
This check is required otherwise we will get below error
java.lang.AssertionError: duplicate context value
at com.sun.tools.javac.util.Context.put(Context.java:141)
at org.netbeans.modules.java.source.nbjavac.parsing.TreeLoader.preRegister(TreeLoader.java:106)
at org.netbeans.modules.java.source.nbjavac.parsing.TreeLoader$TreeLoaderRegistryImpl.enhance(TreeLoader.java:579)
at org.netbeans.modules.java.source.parsing.JavacParser.lambda$createJavacTask$10(JavacParser.java:796)
geertjanw
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nd libs.javaimpl modules with nb-javac jar for jdk-13
Changes:
Find below the list of test-cases which are failing with nb-javac (for jdk-13) but the same scenario is working in editor when used with nb-javac plugin for jdk-13
https://issues.apache.org/jira/browse/NETBEANS-3099