New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NETBEANS-3311] Providing support convert text block to string #1646
Merged
ebarboni
merged 4 commits into
apache:master
from
Akshay-Gupta-19:nb_textBlock_to_string2
Jan 30, 2020
Merged
[NETBEANS-3311] Providing support convert text block to string #1646
ebarboni
merged 4 commits into
apache:master
from
Akshay-Gupta-19:nb_textBlock_to_string2
Jan 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following PR got closed accidentally while rebasing it this is PR for same [NETBEANS-3311] with the changes requested in comments of 1609 Apologies for any inconvenience |
junichi11
added
the
Java
[ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
label
Nov 21, 2019
junichi11
reviewed
Nov 21, 2019
java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertTextBlockToString.java
Show resolved
Hide resolved
junichi11
reviewed
Nov 21, 2019
java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertTextBlockToString.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Nov 21, 2019
java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertTextBlockToString.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Nov 21, 2019
java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertTextBlockToString.java
Outdated
Show resolved
Hide resolved
junichi11
reviewed
Dec 4, 2019
java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertTextBlockToString.java
Outdated
Show resolved
Hide resolved
sdedic
requested changes
Dec 5, 2019
java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertTextBlockToString.java
Outdated
Show resolved
Hide resolved
java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertTextBlockToString.java
Show resolved
Hide resolved
java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertTextBlockToString.java
Outdated
Show resolved
Hide resolved
java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertTextBlockToString.java
Outdated
Show resolved
Hide resolved
java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertTextBlockToString.java
Outdated
Show resolved
Hide resolved
java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertTextBlockToString.java
Outdated
Show resolved
Hide resolved
java/java.hints/src/org/netbeans/modules/java/hints/jdk/ConvertTextBlockToString.java
Outdated
Show resolved
Hide resolved
@sdedic |
arusinha
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
@ebarboni please review it. can it be accommodated in 11.3?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Java
[ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives a warning for every Text block and provide a fix for converting Text blocks to String.
https://issues.apache.org/jira/browse/NETBEANS-3311