Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-3311] Providing support convert text block to string #1646

Merged
merged 4 commits into from Jan 30, 2020

Conversation

Akshay-Gupta-19
Copy link
Contributor

@Akshay-Gupta-19 Akshay-Gupta-19 commented Nov 21, 2019

Gives a warning for every Text block and provide a fix for converting Text blocks to String.
https://issues.apache.org/jira/browse/NETBEANS-3311

@Akshay-Gupta-19
Copy link
Contributor Author

Akshay-Gupta-19 commented Nov 21, 2019

Following PR got closed accidentally while rebasing it this is PR for same [NETBEANS-3311] with the changes requested in comments of 1609
#1609

Apologies for any inconvenience

@arusinha arusinha self-requested a review November 21, 2019 07:01
@junichi11 junichi11 removed the nb11.3 label Nov 21, 2019
@junichi11 junichi11 added this to the 11.3 milestone Nov 21, 2019
@junichi11 junichi11 added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Nov 21, 2019
@junichi11 junichi11 requested a review from sdedic December 4, 2019 21:36
@Akshay-Gupta-19
Copy link
Contributor Author

@sdedic
Done with the changes.

Copy link

@arusinha arusinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Akshay-Gupta-19
Copy link
Contributor Author

@ebarboni please review it. can it be accommodated in 11.3??

@ebarboni ebarboni merged commit 9e0a101 into apache:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants