[NETBEANS-3420] Update Gradle Code Coverage Support for Java 13 #1647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well it is a bit more than that. It separates the the code coverage support from Gradle Java support. Upgrades JaCoCo runtime to 0.8.5 (which supports Java13)
Also moved the ASM dependency to the NetBeans ASM module.
While previously we shipped the ASM all package with NetBeans ASM module we reduced ith to the core and tree api when upgraded to 7.2. JaCoCo needs the common, so I added that support to the ASM module.
We might need a few version increase. Please point out that, where you feel it. Like the lately ASM change increased a minor version 5.9 -> 5.10 where I think we should have used 7.2.