Backport NETBEANS-3290 fix to 11.2 release branch. #1674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assumption of being in root were false. fixing delta in path (cherry picked from commit 14eca85)
geertjanw
approved these changes
Nov 26, 2019
|
@geertjanw yes, seems to apply OK locally, but a bit concerned about the structure of this one compared to other updates. Still, if it does cause any issues in updating we can always revert the update catalog reference for that one NBM. |
|
OK, tests passed so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any comments @jlahoda / @geertjanw on shipping updates to the platform harness via NBM update?