Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NETBEANS-3608] - cleanup hash raw types #1792

Merged
merged 1 commit into from Dec 19, 2019
Merged

[NETBEANS-3608] - cleanup hash raw types #1792

merged 1 commit into from Dec 19, 2019

Conversation

BradWalker
Copy link
Member

There are many places in hte code where the following warning msgs are printed.

[repeat] /home/bwalker/src/netbeans/enterprise/web.jsf/src/org/netbeans/modules/web/jsf/JSFFrameworkProvider.java:127: warning: [rawtypes] found raw type: HashSet
[repeat] Set result = new HashSet();
[repeat] ^
[repeat] missing type arguments for generic class HashSet
[repeat] where E is a type-variable:
[repeat] E extends Object declared in class HashSet

This code change cleans up a lot of those messages.

[NETBEANS-3608] - cleanup hash raw types
61eecf5 
There are many places in hte code where the following warning msgs are printed.

   [repeat] /home/bwalker/src/netbeans/enterprise/web.jsf/src/org/netbeans/modules/web/jsf/JSFFrameworkProvider.java:127: warning: [rawtypes] found raw type: HashSet
   [repeat]         Set result = new HashSet();
   [repeat]                          ^
   [repeat]   missing type arguments for generic class HashSet<E>
   [repeat]   where E is a type-variable:
   [repeat]     E extends Object declared in class HashSet

This code change cleans up a lot of those messages.
mklaehn
mklaehn approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@mklaehn mklaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

matthiasblaesing
matthiasblaesing approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - looks sane. Thank you.

@matthiasblaesing matthiasblaesing merged commit 1a23299 into apache:master Dec 19, 2019
@BradWalker BradWalker deleted the cleanup_hash_rawtypes branch December 19, 2019 16:59
@junichi11 junichi11 added this to the 11.3 milestone Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

@mklaehn mklaehn mklaehn approved these changes

Assignees
No one assigned
Labels
Code cleanup
Projects
None yet
Milestone
11.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BradWalker @matthiasblaesing @mklaehn @junichi11