Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NETBEANS-3204] Add space before arrow in switch case #1793

Merged
merged 1 commit into from Jan 15, 2020
Merged

[NETBEANS-3204] Add space before arrow in switch case #1793

merged 1 commit into from Jan 15, 2020

Conversation

graben
Copy link
Contributor

@graben graben commented Dec 18, 2019

No description provided.

@jlahoda
Copy link
Contributor

jlahoda commented Dec 21, 2019

I think this is a move in a good direction, but I wonder if:
-the spaces around the arrow should be customizable (although could be done separately as well)
-if there is no block after the case ->, the follow-up statement should be put at the same line as the case (which is presumably a separate thing)

@graben
Copy link
Contributor Author

graben commented Jan 6, 2020

@jlahoda : Ready to merge?

@graben
Copy link
Contributor Author

graben commented Jan 13, 2020

@jlahoda : Can we get this into 11.3?

@graben graben requested a review from jlahoda January 14, 2020 17:33
jlahoda
jlahoda approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@jlahoda jlahoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jlahoda jlahoda merged commit 2c314d2 into apache:master Jan 15, 2020
@graben graben deleted the NETBEANS-3204 branch January 15, 2020 07:02
@junichi11 junichi11 added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Jan 15, 2020
@junichi11 junichi11 added this to the 11.3 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlahoda jlahoda jlahoda approved these changes

Assignees
No one assigned
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Milestone
11.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@graben @jlahoda @junichi11