[NETBEANS-3666] improve performance of multitabs on startup if many files are open #1848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkishalmi
reviewed
Jan 5, 2020
| // The HTML rendering makes startup slow (and CPU load high). | ||
| // To workaround this, remove the leading "<html>" if text does not | ||
| // contain HTML tags or entities. | ||
| String prefix = "<html>"; |
There was a problem hiding this comment.
//NOI18N at the end of the line please.
|
Seems to be pretty harmless. |
|
Next time you can really do an amended forced push for such small changes, so I can just rebase and merge it. |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix/workaround the startup performance problem if many files are open and multitabs are used (which is not the default).
There are actually two problems:
getPreferredWidth()is invoked very often from the multitabs table listener (~60000 times for 200 open files)This PR addresses only 2.