NETBEANS-3580] : Fixed Debug Expression Lambda #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entlicher
reviewed
Apr 20, 2020
| .stream() | ||
| .collect(groupingBy(loc->loc.method().toString(), | ||
| LinkedHashMap::new, | ||
| collectingAndThen(minBy(Comparator.comparingDouble(Location::codeIndex)), |
There was a problem hiding this comment.
It's better to use Comparator.comparingLong
There was a problem hiding this comment.
comments addressed.
There was a problem hiding this comment.
Please squash the commits before merging
entlicher
approved these changes
Apr 20, 2020
|
+1 Approved, thanks for fixing this Akhilesh |
…ll location event coming from vm
singh-akhilesh
force-pushed
the
lambda-debug-breakpoint-netbeans-3580
branch
from
3748327
to
61e57e8
Compare
|
@ebarboni Please consider this PR to release 12.0 |
|
The consideration should happen before merging - we're in freeze - if it's in master it's in 12.0! |
|
My mistake, I shouldn't had merged. I will tag Eric from next PR onward if I found it necessary for 12.0 and will not merge |
|
No stress. Mistake happens, Would be nice to have a kind reminder on the github ui but .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/NETBEANS-3580