Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NETBEANS-3311] Convert TextBlock to String, Function call parameter fix #2089

Merged
merged 1 commit into from Apr 29, 2020
Merged

[NETBEANS-3311] Convert TextBlock to String, Function call parameter fix #2089

merged 1 commit into from Apr 29, 2020

Conversation

Akshay-Gupta-19
Copy link
Contributor

If a TextBlock was present in a function call, previous hint does not converts it to String. This PR is to fix (and test)that bug.

@Akshay-Gupta-19 Akshay-Gupta-19 changed the title [NETBEANS-3311] Convert TextBlock to String Function call parameter fix [NETBEANS-3311] Convert TextBlock to String, Function call parameter fix Apr 19, 2020
lahodaj
lahodaj approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be better to have tests in java.source.base, but OK.

@ebarboni ebarboni added this to the 12.0 milestone Apr 28, 2020
@arusinha arusinha merged commit 12ec73d into apache:master Apr 29, 2020
@arvindaprameya
Copy link

+1 approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahodaj lahodaj lahodaj approved these changes

@arusinha arusinha arusinha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Akshay-Gupta-19 @arvindaprameya @lahodaj @arusinha @ebarboni