[NETBEANS-4368] Fix test file navigation dialog #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes resizing of test file selection when navigating to test file. Files are sorted by path.
|
@junichi11 @tmysik Please review. |
|
Relevant NetBeans issue here. |
tmysik
reviewed
May 25, 2020
| @@ -54,6 +55,14 @@ | |||
| private static final Logger LOGGER = Logger.getLogger(GoToTest.class.getName()); | |||
| private static final RequestProcessor RP = new RequestProcessor(GoToTest.class.getName(), 2); | |||
|
|
|||
| private static class FileObjectComparator implements Comparator<FileObject> { | |||
There was a problem hiding this comment.
Just a note: I usually put the inner classes at the very end of the class (usually below //~ Inner classes comment). No need to change it in this PR, I just think it makes the code more readable (main class and then inner classes, not mixed).
|
Thanks for the PR! |
|
@KacerCZ Please attach screenshots(before and after) if possible. Thanks for your contribution. |
|
@junichi11 I added screenshots to first comment. |
|
So, can we merge it? |
|
@tmysik No. NetBeans 12.0 has not been released yet. I'll let you know when we can do that :) |
|
@junichi11 OKOK, merging will be on you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes resizing of test file selection when navigating to test file.
Files are sorted by path.
Before:
After:
