Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End user oriented README.md and dedicated BUILD.md #2546

Merged
merged 7 commits into from
Nov 19, 2020
Merged

End user oriented README.md and dedicated BUILD.md #2546

merged 7 commits into from
Nov 19, 2020

Conversation

JaroslavTulach
Copy link

@JaroslavTulach JaroslavTulach commented Nov 19, 2020 •
edited

Improving README.md to look better in VS Code user interface:

obrazek

Plus backporting fix for #2538

@JaroslavTulach JaroslavTulach requested review from dbalek and jlahoda and removed request for dbalek November 19, 2020 09:25
@JaroslavTulach JaroslavTulach self-assigned this Nov 19, 2020
@JaroslavTulach JaroslavTulach added this to the 12.2 milestone Nov 19, 2020
dbalek
dbalek approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@dbalek dbalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now

@JaroslavTulach
Copy link
Author

CCing @geertjanw: this pull request links to wikipage that you are just improving.

@lkishalmi lkishalmi mentioned this pull request Nov 19, 2020
Merged
lkishalmi
lkishalmi requested changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the change in platform properties it shall be included with #2548

@lkishalmi
Copy link
Contributor

I'm soryy for force pushing the removal of the properties change.

@lkishalmi lkishalmi merged commit d73d3dd into apache:delivery Nov 19, 2020
@JaroslavTulach
Copy link
Author

Thanks Laszlo for polishing the history and separating the backport into #2548. I've meant this PR as a single "VS Code fixes for RC3", but you are right, having the intentions separated is cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jisedlac jisedlac jisedlac left review comments

@lkishalmi lkishalmi lkishalmi approved these changes

@dbalek dbalek dbalek approved these changes

@jlahoda jlahoda Awaiting requested review from jlahoda

Assignees

@JaroslavTulach JaroslavTulach

Labels
None yet
Projects
None yet
Milestone
12.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JaroslavTulach @lkishalmi @dbalek @jisedlac