Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-5114] add missing namespace for facelets composition template client #2613

Merged
merged 1 commit into from Apr 16, 2021

Conversation

jherkel
Copy link
Contributor

@jherkel jherkel commented Dec 28, 2020

@matthiasblaesing
Copy link
Contributor

I could not reproduce the problem - a reproducer on the issue would be good. While I understand, that the namespace declaration is necessary to get valid xml, the issue is about a different problem statement.

@matthiasblaesing matthiasblaesing added this to the 12.4 milestone Jan 31, 2021
@geertjanw
Copy link
Member

Seems to be no clarity on this yet, are we sure this fixes the stated problem, and won't lead to side effects? Changing milestone to 12.5.

@geertjanw geertjanw modified the milestones: 12.4, 12.5 Apr 16, 2021
@brooksie
Copy link

Geertjan, what specifically do you need to see in order to make you happy?
The proposed fix is as simple as it gets - a 1 line fixed-text addition to a template file. It would be easy enough to amend the reproducer to demonstrate that the error goes away when the namespace is added - that's exactly what I do manually (and repeatedly) at the moment to resolve the issue myself as a netbeans user. Including it in the default generated template takes away those manual, repeated edits. But your question is wider than that - are there any situations where including this in the generated ui:composition header would break the code. Perhaps you need to pose your question to your Netbeans JSF expert, or to someone in the expert panel working on the JSF specifications? Bauke Scholtz comes to mind.
FYI here is a couple of postings on Stackoverflow from Bauke Scholtz, known there as BalusC, showing the correct usage of ui:composition as a facelets template client. They all include the basic xmlns:
https://stackoverflow.com/questions/4792862/how-to-include-another-xhtml-in-xhtml-using-jsf-2-0-facelets
https://stackoverflow.com/questions/8500894/how-to-change-head-elements-of-a-page-when-using-uicomposition
From wikipedia: https://en.wikipedia.org/wiki/Facelets#Templating (see "template client" heading)

@matthiasblaesing
Copy link
Contributor

Lets get this in - the xmlns is not strictly necessary, but people will likely add html, so it keeps them happy. As delivery has not yet branched, still merging.

@matthiasblaesing matthiasblaesing merged commit 9ff3f4f into apache:master Apr 16, 2021
@matthiasblaesing matthiasblaesing modified the milestones: 12.5, 12.4 Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants