Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NETBEANS-5177] Fix file descriptor leak in GradleModuleFileCache21 #2666

Merged
merged 1 commit into from Jan 11, 2021

Conversation

lkishalmi
Copy link
Contributor

Trivial fix to close the Stream using try with resources.

@lkishalmi lkishalmi added this to the 12.3 milestone Jan 11, 2021
@lkishalmi
Copy link
Contributor Author

lkishalmi commented Jan 11, 2021

@JaroslavTulach I do not know how this would affect your 12.2.1 release for VS Code, you might want to backport it there...

@lkishalmi lkishalmi merged commit 39467f7 into apache:master Jan 11, 2021
@lkishalmi lkishalmi changed the title [NETBEANS-5177] Fix filehandle leak in GradleModuleFileCache21 [NETBEANS-5177] Fix file descriptor leak in GradleModuleFileCache21 Jan 11, 2021
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Thank you for the quick fix!

@JaroslavTulach
Copy link

@JaroslavTulach I do not know how this would affect your 12.2.1 release for VS Code, you might want to backport it there...

I guess I missed my chance. Let's include it in 12.3 version of VSCode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants