[NETBEANS-5484] Clear NB Non-Project cache when we have more info from Gradle #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is an additional fix for NETBEANS-5484. The root cause of NETBEANS-5484 is that NetBeans evaluates a directory as non-project, since the applied heuristics can't tell otherwise. However after NB turned to Gradle for the exact project information, Gradle updates it's sub project information.
So after all of these when the user clicks on the Sub projects node. Upon the full information in the Gradle Project NB can ask for a project on a directory which previously identified as non-project so returning null instead of evaluating that directory again.
This simple fix clears the NB non-project cache when more information is available from Gradle, so the re-evaluation would happen and identify the directory as a project.