Fixing newly created cpplite project, avoiding starting the C/C++ LSP server when the configuration is not readable. #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… server when the configuration is not readable.
| @@ -78,6 +80,7 @@ public Set instantiate() throws IOException { | |||
| Preferences prefs = CPPLiteProject.getRootPreferences(projectDirectory); | |||
| prefs.putBoolean(CPPLiteProject.KEY_IS_PROJECT, true); | |||
| settings.getBuildConfig().save(getBuildPreferences(projectDirectory)); | |||
| getRootPreferences(projectDirectory).put(KEY_COMPILE_COMMANDS, settings.getEditorConfigPath()); | |||
There was a problem hiding this comment.
I suggest to use the following, to be inline with the existing code in line 81:
Suggested change
| getRootPreferences(projectDirectory).put(KEY_COMPILE_COMMANDS, settings.getEditorConfigPath()); | |
| prefs.put(KEY_COMPILE_COMMANDS, settings.getEditorConfigPath()) |
| LOG.log(Level.WARNING, null, ex); | ||
| return null; | ||
| } | ||
| } else if (config.commandJsonPath != null && commandsPath.canRead()) { |
There was a problem hiding this comment.
I would simplify to
Suggested change
| } else if (config.commandJsonPath != null && commandsPath.canRead()) { | |
| } else if (commandsPath != null && commandsPath.canRead()) { |
| import static org.netbeans.modules.cpplite.project.CPPLiteProject.getBuildPreferences; | ||
| import static org.netbeans.modules.cpplite.project.CPPLiteProject.getRootPreferences; |
There was a problem hiding this comment.
Can be dropped with the change in line 83.
matthiasblaesing
added a commit
that referenced
this pull request
May 23, 2021
Import changes from #2877 and do followup fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.