Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NETBEANS-5744] Avoid java.io deadlock of close vs. pending read. #2986
[NETBEANS-5744] Avoid java.io deadlock of close vs. pending read. #2986
Changes from all commits
ba5bb8a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this explicit close, the
PipedInputStream
won't wake up or receive-1
from the writer (which causes itsread
to return and release lock):super.close() would block on monitor of this Piped stream that would be still waiting on (never coming) input.
Full thread dump:
threaddump-pipedstream.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this explicit close, the following lockup occurs when LSP client initiates the process:
The cancel request waits in
sun.nio.cs.StreamDecoder.close
blocked on monitor held by pendingsun.nio.cs.StreamDecoder.read
Because of NETBEANS-2038, streams are closed before Gradle is instructed to stop the build. It could be possible to flag + filter the streams in Gradle, or close input stream after instructing Gradle to stop. The
PipedInputStream
waits on an input from LSP client which might never come.Full thread dump:
threaddump-streamdecoder.txt