Source/javadoc attacher must report download actions as enabled. #3029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
kind:bug
JaroslavTulach
approved these changes
Jul 1, 2021
lkishalmi
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of work on 'Continuous' gradle mode, the infrastructure started to test actions for
isEnabled()before actually invoking them. That broke source+javadoc attacher introduced in 12.4, that downloads sources/javadocs for the user - the java code never reported the actions as 'enabled', but carried them out anyway. And to be even better, the attacher relied on ActionProgress to reportfinishedwhich never happened, since gradle'sActionProviderImplreturned silently without reporting anything if the client invoked a disabled action.As a result, the Attacher blocked, the user needs to cancel it from the UI (or will run indefinitely if run headless).