NETBEANS-5956: Adding default java trust store to xml retriever #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* A valid certificate should not popup a confirmation dialog * A valid wildcard certificate should not popup a confirmation dialog * An expired certificate should popup a confirmation dialog * A self signed certificate should popup a confirmation dialog * Client certificates should be supportde via system properties
The previous implementation did not load the default java trust store which is added by this commit.
asbachb
changed the title
ide/xml.retriever/src/org/netbeans/modules/xml/retriever/impl/SecureURLResourceRetriever.java
Show resolved
Hide resolved
|
I think we indeed should have a follow up, but in any case this improves the situation with minimal problems. I'm willing to merge, if you agree, that you read the comments in the license statements at the top of the files and agree to donate the change to the ASF. Thank you. |
|
@matthiasblaesing Surely I agree. Happy to contribute to my favourite IDE. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation does not include the default java trust store to validate https connections. This results into a popup asking the user to if he trusts the certificate.
This change adds the default java trust store to the validation logic. In addition some code cleanup were performed.