Fixes creation of a Glassfish deployment descriptor #3219
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix PR that fixes the creation of
glassfish-web.xml
deployment descriptor.Issue 1:
If the server is not assigned to the project then glassfish-web.xml path is incorrect.
Fixed by checking the relative path of standard DD
web.xml
.Issue 2:
Old Java EE and J2EE
glassfish-web.xml
templates no more exist and check for WebApp version 4.0 not added togetSunDDFromProjectsModuleVersion
which skips the creation ofglassfish-web.xml
.Fixed by returning the template
org-netbeans-modules-glassfish-eecommon-ddtemplates-java_ee/glassfish-web.xml
.