Upgrade to Apache Maven 3.8.3

[ebarboni]

Hi, upgrading 3.8.3 in the maven.embedder. Seems very fast on reactor build compare to previous.

I hope I catch all the file to license and hash.

[matthiasblaesing]

In general this looks good to me. RAT looks good and eyeballing the maven-embedded zip and looking at the license changes this looks good. I left two inline comments.

I assume this was tested with real projects and they still work correctly.

[ebarboni]

It works for my limited point of view.

[matthiasblaesing]

The update breaks listing dependencies in at least one project for me. This is a "play ground" project and hast a big chunk of dependencies. With the updated maven-embedder the dependencies are not listed anymore.

From a quick look at the netbeans code it looks as if the MavenProject#getArtifacts method changed its beavior and returns an empty list.

[ebarboni]

@matthiasblaesing I'm not sure how it happens but I first was able to see dependencies and after a while dependencies folder became empty.

[neilcsmith-net]

From a quick look at the netbeans code it looks as if the MavenProject#getArtifacts method changed its beavior and returns an empty list.

So possibly this? https://issues.apache.org/jira/browse/MNG-7285

Perhaps check if it can be reproduced with 3.8.1?

[ebarboni]

maybe better to wait for 3.8.4 :D. I just see the speed gain using 3.8.3, maybe would have help default speed but not seeing dependency is worst.

[neilcsmith-net]

Just a note that a fix (actually revert) seems to have been merged into maven 3.8.x branch now, so keep an eye out for 3.8.4 and hopefully this will be OK. Us and Eclipse Maven support waiting on this one! 😄

[ebarboni]

closing waiting for next maven version