[NETBEANS-5599] PHP 8.1 Support: Final class constants part #3331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://issues.apache.org/jira/browse/NETBEANS-5599 - Fix the grammar file - Add `FinalModifierHintError` and `PHP81UnhandledError` - Add unit tests
junichi11
commented
Nov 24, 2021
junichi11
commented
Nov 24, 2021
junichi11
commented
Nov 24, 2021
junichi11
commented
Nov 24, 2021
| * under the License. | ||
| */ | ||
|
|
||
| class FinalMethod { |
There was a problem hiding this comment.
Add missing unit tests for final methods.
|
@tmysik I've started supporting PHP 8.1. Could you please review this when you have time? If there is no problem, let's merge it. I've created the new branch( |
tmysik
approved these changes
Nov 24, 2021
|
@tmysik Thank you as always :) |
|
@junichi11 You are the one doing the great work, not me ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/NETBEANS-5599
RFC: https://wiki.php.net/rfc/final_class_const
FinalModifierHintErrorandPHP81UnhandledErrorScreenshots
PHP Version:
with PHP 8.1
with PHP 8.0
Errors for the final modifier