Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more actions to LSP Projects View #3363

Merged
merged 14 commits into from Dec 14, 2021
Merged

Added more actions to LSP Projects View #3363

merged 14 commits into from Dec 14, 2021

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented Dec 10, 2021

project-actions

The following actions were enabled:

  • PROJECTS (view caption):
    • inline: new project, collapse all
    • context: build workspace, clean workspace, run/debug workspace
  • PROJECT (node):
    • inline: new from template, run/debug project
    • context: clean project, build project, test project
  • PACKAGE (node):
    • inline: new from template
    • context: delete package
      CLASS (node):
    • context: delete class?

@sdedic sdedic added enhancement API Change [ci] enable extra API related tests LSP [ci] enable Language Server Protocol tests labels Dec 10, 2021
@sdedic sdedic added this to the NB13 milestone Dec 10, 2021
@sdedic sdedic self-assigned this Dec 10, 2021
JaroslavTulach
JaroslavTulach reviewed Dec 10, 2021
View reviewed changes
Copy link

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left few questions. I guess I am lost in the highlevel architecture.

...java.lsp.server/nbcode/integration/src/META-INF/services/org.openide.explorer.ExtendedDelete Show resolved Hide resolved
...ava.lsp.server/src/org/netbeans/modules/java/lsp/server/explorer/DefaultDecorationsImpl.java Show resolved Hide resolved
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/LspTemplateUI.java Show resolved Hide resolved
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/protocol/ProjectActionParams.java Outdated Show resolved Hide resolved
java/java.lsp.server/vscode/package.json Show resolved Hide resolved
java/java.lsp.server/vscode/package.json Show resolved Hide resolved
@sdedic
Copy link
Member Author

sdedic commented Dec 12, 2021

Rebased on latest master + version bump.

JaroslavTulach
JaroslavTulach approved these changes Dec 14, 2021
View reviewed changes
Copy link

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having an arch.xml document describing the layer API and marking as private is all I can ask for at this stage, I guess. Thank you, Sváťo.

@sdedic sdedic merged commit 166180e into apache:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbalek dbalek dbalek approved these changes

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

Assignees

@sdedic sdedic

Labels
API Change [ci] enable extra API related tests enhancement LSP [ci] enable Language Server Protocol tests
Projects
None yet
Milestone
NB13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sdedic @dbalek @JaroslavTulach