Show Databases and Projects views only after NBLS extension activates. #3371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
kind:bug
sdedic
added
do not merge
jtulach
reviewed
Dec 15, 2021
| }, | ||
| { | ||
| "id": "database.connections", | ||
| "name": "Databases" | ||
| "name": "Databases", | ||
| "when": "nbJavaLSReady" |
There was a problem hiding this comment.
That's horrible token name!
jtulach
approved these changes
Dec 15, 2021
|
Failed in java and random-failure test, vscode ext build is clear; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When vscode starts with a folder that do not contains any nice files like
.javaor.groovy, the Apache NBLS extension does not activate at all ! Still the UI showsProjectsandDatabasesviews, but empty - as the relevantTreeDataProviders are not registered yet.This PR will just make appearance of those views depend on NBLS extension to become ready (it sets up a context variable).