Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change nb.sass.libsass to TRUE, to fix broken SASS #3373

Merged
merged 1 commit into from Dec 16, 2021

Conversation

t-oster
Copy link
Contributor

@t-oster t-oster commented Dec 15, 2021

With default NetBeans modern sass implementations cannot be used, because it defaults to the unmaintained ruby-sass implementation, which supports the command line switch --cache-location.

There is a System property to switch that but it defaults to ruby sass. This PR just changes the default value, so most users can just use modern sass and the minority using ruby-sass can set the value to false expliciteley.

There is still an issue with the sourcemaps option, but until #1234 is sorted out, this PR will make Sass usable again for most users, which is IMHO priority.

@t-oster
Copy link
Contributor Author

t-oster commented Dec 15, 2021

Can somebody explain to me, what the problem with the commit is? I cannot figure out the problem in the tests, nor reproduce them locally.

@matthiasblaesing
Copy link
Contributor

@t-oster not all unittests are rock solid, so some of just fail randomly, I restarted the failing tests and they succeeded now.

As already pointed out in #1234 this is not the final solution - but it is at least a bit better.

Closes: #1234

@matthiasblaesing matthiasblaesing merged commit 2388352 into apache:master Dec 16, 2021
@matthiasblaesing matthiasblaesing added this to the NB13 milestone Dec 16, 2021
@t-oster
Copy link
Contributor Author

t-oster commented Dec 17, 2021

Thanks for the quick reply and merging. Yes, I know this is not the final solution. We should either support different implementations by dropdown or autodetection or just remove all command line flags, which are not present in every commonly used implementation (e.g. remove the source-maps checkbox) and leave it to the user to provide the correct command line.

However just flipping that bit makes it at least possible to use for the vast majority right now without modifying startup scripts, so IMHO this is better.

Maybe we should not close #1234 or at least create a follow-up issue so that somebody can pick up the issue with the different parameters for source maps.

@t-oster t-oster deleted the feature-sass-default branch December 17, 2021 06:33
@t-oster
Copy link
Contributor Author

t-oster commented Dec 17, 2021

(sorry, I forgot #1234 is just a PR and your issues are in bugzilla, so ignore my last comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants