Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite lambda to an inner class to prevent from Gradle warning about execution optimizations. #3377

Merged
merged 1 commit into from Dec 18, 2021

Conversation

entlicher
Copy link
Contributor

When a Micronaut Gradle app is run, following message is printed:

> Task :run
Execution optimizations have been disabled for task ':run' to ensure correctness due to the following reasons:
  - Property 'jvmArgumentProviders.$0' was implemented by the Java lambda 'org.netbeans.modules.gradle.tooling.NetBeansRunSinglePlugin$$Lambda$1154/0x00000008409ea840'. Reason: Using Java lambdas is not supported as task inputs. Please refer to https://docs.gradle.org/7.3.1/userguide/validation_problems.html#implementation_unknown for more details about this problem.

While this is not a severe issue, it's distracting and the user has a little chance to understand what this means.
We need to replace the lambda with an anonymous class in NetBeansRunSinglePlugin to get rid of the message.

@mbien
Copy link
Member

mbien commented Dec 17, 2021

please add a short comment so that nobody converts it to a lambda again in future code cleanups.

@entlicher entlicher added the Gradle [ci] enable "build tools" tests label Dec 17, 2021
@entlicher entlicher added this to the NB13 milestone Dec 17, 2021
Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this one!

@lkishalmi lkishalmi merged commit b93f750 into apache:master Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gradle [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants