Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable client-side projects and nodejs support. #3384

Merged
merged 1 commit into from Dec 21, 2021

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented Dec 20, 2021

The NBLS distribution contains a broken client-side project support: some modules are there, some are not, like HTML parser & co. Given the feature is not really used (vscode as the primary LSP client uses a different langserver for JS, Node) and it is broken anyway, I'd prefer to remove it form the NBLS distribution.

We can later add it back, but with all dependencies so that it really works. Now the client-side project errors out with an exception:

java.lang.IllegalArgumentException: No parser for mime type: text/html
        at org.netbeans.modules.parsing.nb.DataObjectEnvFactory.findMimeParser(DataObjectEnvFactory.java:78)
        at org.netbeans.modules.parsing.api.ParserManager.findParser(ParserManager.java:374)
        at org.netbeans.modules.parsing.api.ParserManager.parseWhenScanFinished(ParserManager.java:339)
        at org.netbeans.modules.web.clientproject.remotefiles.RemoteFiles.update(RemoteFiles.java:77)
        at org.netbeans.modules.web.clientproject.remotefiles.RemoteFiles.getRemoteFiles(RemoteFiles.java:112)
        at org.netbeans.modules.web.clientproject.remotefiles.RemoteFilesNodeFactoryImpl$RemoteFilesNodeListImpl.keys(RemoteFilesNodeFactoryImpl.java:64)
        at org.netbeans.spi.project.ui.support.NodeFactorySupport$DelegateChildren$1.run(NodeFactorySupport.java:177)
        at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418)
        at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)

@sdedic sdedic added kind:bug Bug report or fix LSP [ci] enable Language Server Protocol tests labels Dec 20, 2021
@sdedic sdedic self-assigned this Dec 20, 2021
Copy link

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However it is clear we don't want HTML project.

@sdedic sdedic merged commit 1174d5b into apache:master Dec 21, 2021
@neilcsmith-net neilcsmith-net added this to the NB13 milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Bug report or fix LSP [ci] enable Language Server Protocol tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants