Native image breakpoints work with shared libraries. #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entlicher
force-pushed
the
MoreReliableNIBreakpoints
branch
from
af26af4
to
41355c4
Compare
|
I've just tried a version of the If I first attach, then load my dynamic library, the breakpoint doesn't work. But I can live with it. |
JaroslavTulach
approved these changes
Jan 7, 2022
ide/nativeimage.api/src/org/netbeans/modules/nativeimage/spi/debug/NIDebuggerProvider.java
Outdated
Show resolved
Hide resolved
ide/nativeimage.api/src/org/netbeans/modules/nativeimage/api/debug/NIDebugger.java
Outdated
Show resolved
Hide resolved
...r/src/org/netbeans/modules/java/nativeimage/debugger/breakpoints/JPDABreakpointsHandler.java
Outdated
Show resolved
Hide resolved
… and submit breakpoints based on relative path in sources folder.
entlicher
force-pushed
the
MoreReliableNIBreakpoints
branch
from
41355c4
to
8198024
Compare
|
After all I've abandoned matching file paths in the sources listing as we can not have reliable source list for lazily loaded shared libraries. |
|
The newest version seems to work for my use-case. |
entlicher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting a breakpoint into a Java native image, we consult the list of source files from the executable to determine the correct destination file.
The breakpoint's file is resolved relative to the
sourcesfolder, which is expected to be the sibling of the executable file.When the
sourcesfolder is not found, breakpoints are resolved to locations that do not exist in the executable.To verify the correctness of file paths, we use a newly introduced
NIDebugger.listSources()method.