Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using word failed in non-fatal debug messages #3425

Merged
merged 1 commit into from Jan 7, 2022

Conversation

JaroslavTulach
Copy link

How do you search for failures in Travis and GitHubActions runs? I search for failed like in The test XYZTest failed. However there are other, disturbing occurrences of that word in the test logs. There was 52 occurrences in a recent log. Here are three examples:

 [junit] WARNING: Warning - project of class org.netbeans.modules.java.source.usages.TestSupport$TestProject in /home/runner/work/netbeans/netbeans/java/java.source.base/build/test/unit/work/o.n.m.j.s.u.S/sipwop/prj0 failed to supply a LogicalViewProvider in its lookup
     [junit] SEVERE: Error in RequestProcessor org.netbeans.modules.editor.settings.storage.preferences.PreferencesImpl$1
    [junit] org.openide.util.RequestProcessor$SlowItem: task failed due to: java.lang.NullPointerException: The folder parameter cannot be null
    [junit] 	at org.openide.util.RequestProcessor$Task.schedule(RequestProcessor.java:1459)
    [junit] 	at org.netbeans.modules.editor.settings.storage.preferences.PreferencesImpl.asyncInvocationOfFlushSpi(PreferencesImpl.java:478)
    [junit] 	at org.netbeans.modules.editor.settings.storage.preferences.PreferencesImpl.putSpi(PreferencesImpl.java:274)

and

   INFO: ModificationResult commit failed with an exception: 
    [junit] java.io.IOException
    [junit] 	at org.netbeans.api.java.source.ModificationResult.processDocument(ModificationResult.java:385)
    [junit] 	at org.netbeans.api.java.source.ModificationResult.commit2(ModificationResult.java:330)
    [junit] 	at org.netbeans.api.java.source.ModificationResult.access$000(ModificationResult.java:71)

This PR changes the wording, so the search is easier. Hopefully none of these messages form an important API and no test fails because of changing them.

@mbien
Copy link
Member

mbien commented Jan 7, 2022

excellent! I also added a script recently which lists all failed tests on the very bottom of the log.

@JaroslavTulach JaroslavTulach self-assigned this Jan 7, 2022
@JaroslavTulach JaroslavTulach added this to the NB13 milestone Jan 7, 2022
@dbalek dbalek self-requested a review January 7, 2022 16:53
@JaroslavTulach JaroslavTulach merged commit 1fc9650 into apache:master Jan 7, 2022
@MartinBalin
Copy link
Contributor

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants