Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jackpot] Add sourceVersion(int) to rule file utils and deprecate enum variant. (part 2) #3439

Merged
merged 1 commit into from Jan 14, 2022

Conversation

mbien
Copy link
Member

@mbien mbien commented Jan 10, 2022

I forgot to add a commit to #3395

This is the actual support of int literals for rule conditions - the rule API of part 1 alone won't do anything.

sorry!

@mbien mbien added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Jan 10, 2022
@mbien mbien added this to the NB13 milestone Jan 10, 2022
Copy link
Contributor

@jlahoda jlahoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake I didn't remember there are limitations on the conditions.

@mbien
Copy link
Member Author

mbien commented Jan 14, 2022

@jlahoda thanks for review, merging

@mbien mbien merged commit 4559136 into apache:master Jan 14, 2022
@mbien mbien added the hints label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hints Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants