LSP: java.source.save.CasualDiff: Illegal values after using CodeCompletion. #3475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anything for consideration for NB13 needs rebasing on delivery. |
neilcsmith-net
added
the
do not merge
dbalek
added
do not merge
lkishalmi
pushed a commit
to lkishalmi/netbeans
that referenced
this pull request
Jan 20, 2022
jhorvath
pushed a commit
to jhorvath/netbeans
that referenced
this pull request
Feb 2, 2022
jhorvath
pushed a commit
to jhorvath/netbeans
that referenced
this pull request
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After using code completion for e.g.
System.out, a syntax error due to unfinished statement is usually reported. At the same time VSCode client asks for all available CodeActions (Hints) at the current line. One of the hints offers creating a static import forSystem.outand therefore a diff computation for such change touches theErroneousTreerepresenting the unfinished statement. Change to theCasualDiffwas necessary to correctly handle this situation.