Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report real FULL/FULL_ONLINE quality after load. #3481

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented Jan 20, 2022

I've noticed that when Gradle is executed to configure project & report its properties, the resulting Quality of the project information is still the aimed value - whatever it was. IMHO the info quality should reflect the real state: either FULL_ONLINE if online mode was requested explicitly; or FULL, if the project could be configured without online access (and settings require or permit that).

@sdedic sdedic added the Gradle [ci] enable "build tools" tests label Jan 20, 2022
@sdedic sdedic requested a review from lkishalmi January 20, 2022 12:29
@sdedic sdedic self-assigned this Jan 20, 2022
@sdedic sdedic changed the title Report real FULL/FULL_ONLINE status after load. Report real FULL/FULL_ONLINE quality after load. Jan 20, 2022
Copy link
Contributor

@lkishalmi lkishalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane. Thank you!

@lkishalmi lkishalmi merged commit 91983a4 into apache:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gradle [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants