Ensure BufferedInputStream is not initialized with a buffer size of 0 #3491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With an empty file the BufferedCharSequence fails to be initialized: java.lang.IllegalArgumentException: Buffer size <= 0 at java.base/java.io.BufferedInputStream.<init>(BufferedInputStream.java:207) at org.netbeans.modules.search.matcher.BufferedCharSequence$Source.initStreams(BufferedCharSequence.java:562) Caused: java.io.IOException Caused: org.netbeans.modules.search.matcher.BufferedCharSequence$SourceIOException at org.netbeans.modules.search.matcher.BufferedCharSequence$Source.initStreams(BufferedCharSequence.java:570) at org.netbeans.modules.search.matcher.BufferedCharSequence$Source.<init>(BufferedCharSequence.java:494) at org.netbeans.modules.search.matcher.BufferedCharSequence.<init>(BufferedCharSequence.java:145) [catch] at org.netbeans.modules.search.matcher.MultiLineStreamMatcher.checkMeasuredInternal(MultiLineStreamMatcher.java:84) at org.netbeans.modules.search.matcher.AbstractMatcher.check(AbstractMatcher.java:53) at org.netbeans.modules.search.matcher.DefaultMatcher.checkMeasuredInternal(DefaultMatcher.java:93) at org.netbeans.modules.search.matcher.AbstractMatcher.check(AbstractMatcher.java:53) at org.netbeans.modules.search.BasicComposition.start(BasicComposition.java:78) at org.netbeans.modules.search.SearchTask.run(SearchTask.java:93) at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1418) at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45) at org.openide.util.lookup.Lookups.executeWith(Lookups.java:278) at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2033) So ensure, that at least a 1 byte buffer is used.
|
This was noticed by @neilcsmith-net in #3489 |
mbien
approved these changes
Jan 23, 2022
neilcsmith-net
approved these changes
Jan 24, 2022
There was a problem hiding this comment.
Thanks @matthiasblaesing Hadn't time then to delve further. Looks safest minimal approach - wasn't sure whether to try and skip empty files completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With an empty file the BufferedCharSequence fails to be initialized:
So ensure, that at least a 1 byte buffer is used.