LSP ProjectView test + fixes #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
kind:bug
JaroslavTulach
approved these changes
Jan 25, 2022
There was a problem hiding this comment.
It is sad that two biggest files in the change are gradlew wrappers! I'd prefer to generate them using "gradle init" which is available when one uses "New From Template" on the gradle project. I know you argued that JAR files should rather be in the repository and this is similar issue, so I leave the decision up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focus on integration-testing the projects view. It checks basic scenarios: created files appear, deleted disappear and the package nodes restructure according to the occupied folders.
I moved certain registrations / layer folders from
nbcodeintegration module to LSP module - these are harmless for IDE execution, but the LSP server (which can be potentially started inside NB IDE) does not function without those folders well. AlsofoundProjectsview is defined in the LSP server but its critical cookie registrations were in the integration module - a different distribution.During testing, I've encountered a NPE thrown when the client asks for details of a non-existing node: this is fixed by the last commit.