Parse Indexables under a source root as a group while running EmbeddedIndexers #3516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbalek
added
work-in-progress
do not merge
JaroslavTulach
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
My understanding of the code changes is limited, but:
- reducing the number of
javacinstances by thousands is a great thing - allowing people to use the same API without writing special case of Java support is great too
You have my emotional support and approval!
dbalek
removed
work-in-progress
do not merge
jhorvath
pushed a commit
to jhorvath/netbeans
that referenced
this pull request
Feb 2, 2022
jhorvath
pushed a commit
to jhorvath/netbeans
that referenced
this pull request
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the performance problem found while trying to open and index larger mx based project (GraalVM's Truffle). Because of an EmbeddingIndexer registered for the
text/x-javamime type (TestMethodFinderImpl), thousands of thejavaccompiler instances are created to index the project sources (one instance per source root viaJavaCustomIndexerand instance per source/indexable viaRepositoryUpdater.indexEmbeddings.This change tries to parse all sources/indexables under a source root as a group while running EmbeddedIndexers. Is saves thousands of the
javacinstances (only two instances per source root are created - one viaJavaCustomIndexer, the second viaRepositoryUpdater.indexEmbeddings) and approximately 20% of indexing time for the Truffle mx project.