Download wallet #3546
Merged
Download wallet #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
approved these changes
Feb 1, 2022
java/java.lsp.server/src/org/netbeans/modules/java/lsp/server/ui/NotifyDescriptorAdapter.java
Outdated
Show resolved
Hide resolved
| @@ -188,6 +188,23 @@ | |||
| <specification-version>1.10</specification-version> | |||
| </run-dependency> | |||
| </dependency> | |||
| <dependency> | |||
| <code-name-base>org.openide.filesystems</code-name-base> | |||
There was a problem hiding this comment.
The cloud.oracle is using API from dialogs 7.59 - does it require version 7.59?
| @@ -537,7 +537,7 @@ | |||
| <build-prerequisite/> | |||
| <compile-dependency/> | |||
| <run-dependency> | |||
| <specification-version>7.52</specification-version> | |||
| <specification-version>7.59</specification-version> | |||
| @@ -85,6 +86,9 @@ public static synchronized UIContext find() { | |||
| protected abstract CompletableFuture<MessageActionItem> showMessageRequest(ShowMessageRequestParams msg); | |||
| protected abstract void logMessage(MessageParams msg); | |||
| protected abstract Message showStatusMessage(ShowStatusMessageParams msg); | |||
| protected CompletableFuture<String> showInputBox(ShowInputBoxParams params) { | |||
There was a problem hiding this comment.
Actually, this is an API change in the API of java.lsp.server module. It would deserve module version increment, javadoc, @since tag. I am sorry for not documenting it in my commit that introduced this method.
jhorvath
force-pushed
the
download-wallet
branch
from
3bd242f
to
cc48612
Compare
jhorvath
force-pushed
the
download-wallet
branch
from
cc48612
to
774302c
Compare
dbalek
approved these changes
Feb 7, 2022
Merged
|
All green ! merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download DB wallet action is available in vscode.
NotifyDescriptor.InputLineis displayed in vscode as QuickInput.NotifyDescriptor.PasswordLinedisplays password input dialog.