Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3590] Prevent suspicious NPE forn Gradle SubProjectsNode #3591

Merged
merged 1 commit into from Feb 15, 2022

Conversation

lkishalmi
Copy link
Contributor

This one prepares the code getting null from ProjectUtils.getContainedProjects()


^Add meaningful description above

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

@lkishalmi lkishalmi added the Gradle [ci] enable "build tools" tests label Feb 11, 2022
@lkishalmi lkishalmi added this to the NB14 milestone Feb 11, 2022
@neilcsmith-net
Copy link
Member

Possibly looking at needing an rc4 for NB13 (also NPE related). Maybe this is one to get in too if we do?

@lkishalmi
Copy link
Contributor Author

Well, if we need an RC4 this one could be there as it is trivial.
So if you ping me or the team that we are doing an rc4 I'm gladly rebase this one.

@mbien mbien linked an issue Feb 12, 2022 that may be closed by this pull request
3 tasks
@lkishalmi lkishalmi changed the base branch from master to delivery February 12, 2022 19:21
@lkishalmi lkishalmi modified the milestones: NB14, NB13 Feb 12, 2022
@lkishalmi
Copy link
Contributor Author

@neilcsmith-net Just rebased on delivery. Take this if you wish. It seems I need to take a few strolls on the shores of the Pacific Ocean (wife orders), so I won't be around for a while.

@neilcsmith-net
Copy link
Member

Thanks @lkishalmi - and enjoy your strolls!

@neilcsmith-net neilcsmith-net merged commit 5a1e8be into apache:delivery Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gradle [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible NPE on Gradle SubProjectsNode
2 participants