-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle classfiles with too new versions. #3598
Conversation
awesome :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran some manual tests and I could open and edit ea JDK 19 loom/panama projects while using nb-javac and running NB on JDK 17. Auto completion, rename refactoring, jackpot scripts etc all worked with no exceptions in the log.
There will be another rc for NB 13 on Tuesday. From a certain perspective this could be seen as a bug fix. Might be worth to rebase to delivery. |
4ef1e22
to
5f863e3
Compare
I can rebase, I think, but I'll leave it up to @neilcsmith-net is he would be interested to include this in NB 13. To me, seems it could wait for the next version, though. |
(Thanks for testing and spotting the typo, BTW!) |
Well, I've no more say than anyone else what goes in NB13! However, I do have reservations about dropping this in so late. I'm also curious what the implications are with things like Compile on Save? Hard fail with workaround in NB13, and aiming to look at a better experience for this in NB14 seems a good move to me. |
This was proposed to NB13, anyone objecting merging it? |
Got approved, tests seems to be happy. I'm merging this one. |
javac normally refuses to load classfiles that are too new (unlike old nb-javac). Classfile versions change fairly frequently, but javac can often load the newer classfiles anyway. So let's try to load them, as did nb-javac. (It will be a bit slower to read the too-new classfile, but I think that is mostly fine.)
Based on a report from here:
https://lists.apache.org/thread/gtv4nnhvjtzqrk8zmsojj70blw0n18yv