Native Image debugger does not set print objects on. Checks added to prevent from exceptions. #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to retrieve runtime type information from native image, we must not set "print objects" GDB setting to "on". When it's on, we get some memory access issues from GDB.
To be able to turn it off for native image debugging (we want to have it on for C/C++), we need to add
displayObjectsflag intoStartDebugParameters. We need to have it for both launch and attach, thus I've addedprocessIdas well and deprecatedattachmethod.Retrieval of runtime type information is added into
JavaVariablesDisplayerand some additional checks are added to prevent from exceptions.