Fixed endless CompletionStage chaining. #3621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
kind:bug
JaroslavTulach
approved these changes
Feb 17, 2022
dbalek
approved these changes
Feb 17, 2022
sdedic
force-pushed
the
lsp/endless-getNodeId
branch
from
403b533
to
2d010f9
Compare
|
Conflicted with another merged PR -- rebased on latest master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes
TreeNodeProvider.getNodeId()call, which was supposed to find (or create) node LSP ID. The original code chained CompletableStages endlessly, eventually runnin OOM. The code was also not updated sufficiently as the rest of code evolved. SinceholdChildrenis now supposed to contain entries for all nodes known to the client, the fix will create these records for all nodes up to the root.