Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSF: Declaration of the xmlns namespace is reported as missing library #3636

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

matthiasblaesing
Copy link
Contributor

No description provided.

@vieiro
Copy link
Contributor

vieiro commented Feb 19, 2022

It's surprising this was reported as a missing library.

@matthiasblaesing
Copy link
Contributor Author

I added a missing "//NOI18N" marker and will merge when Unittests come back.

The reason for the missing library report is, that all namespace mappings are expected to be JSF libraries. What was overlooked is, that there might be a reason to declare a schema location (in our case the XHTML namespace is referenced). Other might map other normal XML namespaces, but I wanted to keep this minimal and a straight forward fix.

@vieiro
Copy link
Contributor

vieiro commented Feb 19, 2022

@matthiasblaesing Yep. In the future I think we should have a list of most used namespaces in the web we should be skipping (say SVG).

Note that is you skip the XML Schema namespace you may be wanting to skip XLink as well, which is a common companion of XML Schema.

@matthiasblaesing matthiasblaesing merged commit 18b85fb into apache:master Feb 19, 2022
@matthiasblaesing matthiasblaesing deleted the jsf_fix branch February 26, 2022 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants