Improve CSS Support #3642
Merged
Improve CSS Support #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3 tasks
The semicolon is optional reading the examples. This change implements: semicolons are required after property declarations, but not after margin declarations.
matthiasblaesing
force-pushed
the
css_ext
branch
from
293093d
to
7639dc8
Compare
|
I intent to merge this next weekend. If you want to object, feel free to do so. |
vieiro
approved these changes
Feb 23, 2022
|
Hi, I have a very naive question. I only see that for css we use antlr 3.x and the current antlr is 4.x. I'm not aware how many grammar we have in codebase. But would it be an idea to migrate to last ? |
|
Without a good argument I think it would be no benefit. Rewriting the grammar just poses chances to break the code. |
|
@ebarboni @matthiasblaesing AFAIK Antlr4 exposes the AST through the visitor pattern (or through events), i.e., you don't have it in memory. The migration Antlr3 to Antlr4 is not straightforward. You'll have to build the AST yourself (see, https://stackoverflow.com/questions/29971097/how-to-create-ast-with-antlr4 for instance). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce partitial support for CSS Selector Level 4 (:not, :where, :is)
Before:
After:
Improve parsing of the contents of @page declarations
Before:
After: