Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSPBindings synchronization fix #3644

Merged
merged 1 commit into from
Feb 20, 2022
Merged

LSPBindings synchronization fix #3644

merged 1 commit into from
Feb 20, 2022

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Feb 19, 2022

Adds some extra synchronized blocks around those non thread-safe maps.

matthiasblaesing
matthiasblaesing approved these changes Feb 20, 2022
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I read this correctly, the intention is to protect workspace2Extension2Server and project2MimeType2Server from access from multiple threads. Looks sane to me.

@vieiro
Copy link
Contributor Author

vieiro commented Feb 20, 2022

Exactly. There're some "synchronized" methods in LSPBiindings, that do protect these maps from being accessed from multiple threads, but these small parts were missing.

@vieiro vieiro merged commit 646f84c into apache:master Feb 20, 2022
@vieiro vieiro mentioned this pull request Feb 20, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vieiro @matthiasblaesing