Cleanup deprecated constructor use #3649
Conversation
Cleaning some old code to make it more current.. - removed use of old deprecated constructor use - use autobox/unbox for encapsulation - change chain-of-if statement to switch w/ string - some code cleanup
| break; | ||
|
|
||
| default: | ||
| break; |
There was a problem hiding this comment.
the intention is good but i think this makes it more difficult to read.
try to format it like:
case "[Z": typeObj = HprofHeap.BOOLEAN; break; // NOI18NIts non-standard but would be compact and easier to read in this particular case. The "// NOI18N" hint must be on the same line as the String literal.
Formatting it like this is also really close to switch expressions of later JDKs. Updating to them would only require the "->" and removal of "break".
But most importantly: we have to be careful with null here. What if vmName is null? The switch will throw an exception, the if-else would do fine.
| case "GET": | ||
| // NOI18N |
There was a problem hiding this comment.
same here: // NOI18N must be on the same line behind case "foo"
|
@BradWalker please don't merge PRs without giving others a chance to review - even if it seems trivial. |
|
@mbien , sorry about that.. I got a little bit aggressive with this.. My sincere apologies.. I'll get it fixed.. |
Cleaning some old code to make it more current..
^Add meaningful description above
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.