Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore dependencies for BOM-like projects. #3668

Merged
merged 3 commits into from
Feb 28, 2022

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented Feb 24, 2022

Following suggestion in NETBEANS-5846. The ProjectInfoBuilder in gradle-tooling was changed so it does not produce unresolved_problems if the project uses javaPlatform plugin w/ dependencies enabled.

The 2nd commit is a bugfix - during testing, I used Reload Project action and the project did not degrade to the new (broken) state after change in buildscript + reload. My fault, the force parameter to loadProject was not used at all.

@sdedic sdedic added enhancement Gradle [ci] enable "build tools" tests labels Feb 24, 2022
@sdedic sdedic added this to the NB14 milestone Feb 24, 2022
@sdedic sdedic self-assigned this Feb 24, 2022
@lkishalmi
Copy link
Contributor

Looks good, though you might also would like to bump this number:

private static final int COMPATIBLE_CACHE_VERSION = 19;

That would make disk cache invalid and force NB to re-load the project info.

@sdedic
Copy link
Member Author

sdedic commented Feb 28, 2022

Feedback incorporated, 3 days from approval; merging.

@sdedic sdedic merged commit 13dd3a4 into apache:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Gradle [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants