Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating nb-javac to version 18. #3729

Merged
merged 10 commits into from
Mar 21, 2022
Merged

Updating nb-javac to version 18. #3729

merged 10 commits into from
Mar 21, 2022

Conversation

dbalek
Copy link
Contributor

@dbalek dbalek commented Mar 8, 2022

Created to run all NB tests for nb-javac-18.

@dbalek dbalek added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Mar 8, 2022
@JaroslavTulach
Copy link

There is a failure in java.mx.projects tests:

$ nbbuild/travis/print-junit-report.sh
=================== JUnit Report Summary / failed tests ===================
org.netbeans.modules.java.mx.project.SdkSuiteTest
      failed: testParseSdkSourcesWithoutError
====================== JUnit failure details ===============================

that's potentially concerning.

@dbalek dbalek removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Mar 21, 2022
JaroslavTulach
JaroslavTulach approved these changes Mar 21, 2022
View reviewed changes
Copy link

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing update! Thanks a lot.

@dbalek dbalek merged commit e041446 into apache:master Mar 21, 2022
@dbalek dbalek deleted the dbalek/nb-javac-18 branch March 21, 2022 16:06
@mbien mbien added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Mar 21, 2022
@mbien mbien added this to the NB14 milestone Mar 21, 2022
@mbien mbien mentioned this pull request Mar 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaroslavTulach JaroslavTulach JaroslavTulach approved these changes

Assignees
No one assigned
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Milestone
NB14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbalek @JaroslavTulach @mbien